Please use english language
It is currently 19 Nov 2017, 01:13

All times are UTC





Post new topic Reply to topic  [ 18 posts ]  Go to page Previous  1, 2
Author Message
PostPosted: 25 Oct 2017, 23:34 
Offline
*sensei*
User avatar

Joined: 12 Aug 2013, 18:55
Posts: 269
Location: Scotland
So it seems that the tempF variables are bugged; assigning variables in enbeffect.fx to them causes the shader to not run properly. No error is thrown, but the game's original post processing is used (toggling ENB does nothing). Changing the variables also doesn't affect the visuals in any way.

Here's the enbeffect.fx file, the tempF vars are used after the APPLYGAMECOLORCORRECTION block, rest of it is the same as the Pastebin in the OP: https://pastebin.com/RWBDsaYB

_________________
Intel i7 6700k | AMD HD 7850 2GB | 2x16GB DDR4 @ 3000mhz | Windows 7 64bit | Creative Soundblaster X-Fi Titanium Fatal1ty Pro | Asus z170 Pro Gaming


Top
 Profile  
 
Tomoko
PostPosted: 26 Oct 2017, 18:36 
Offline
*sensei*

Joined: 30 Jan 2012, 13:18
Posts: 483
I'm not sure if you can change globally declared variables inside the pixel shader. Most likely you broke the shader but the enb for oblivion doesn't output compiler errors as it does on SSE for example.


Top
 Profile  
 
PostPosted: 26 Oct 2017, 21:01 
Offline
*sensei*

Joined: 05 Apr 2014, 10:29
Posts: 498
Location: Taiwan
you can use local var,
Code:
//inside shader
   float GammaDay = tempF1.x; //local variable prioritize before global var
   //other stuffs...
   float fGamma = lerp(lerp(GammaNight, GammaDay, ENightDayFactor), GammaInterior, EInteriorFactor);

or use static global
Code:
//move enbparams at the start of file
//+++++++++++++++++++++++++++++
//external parameters, do not modify
//+++++++++++++++++++++++++++++
//...
//
    //begin NLA Color
static float   GammaDay = tempF1.x; //line 53 in pastbin

//then the shaders...

u can also do this as global var,
Code:
   static float Gamma = lerp(lerp(GammaNight, GammaDay, ENightDayFactor), GammaInterior, EInteriorFactor);

mostly they're just eye candy for easy access, but it is quite useful for quick test on params.

and again, I would recommend using fxc.exe to debug if you're doing intensive coding.

_________________
Intel Xeon L5639 6C12T @3.96GHz // Gigabyte ga-x58a-ud3r// MSI GTX680 4G// 24G RAM
Flickr
YouTube


Top
 Profile  
 
PostPosted: 26 Oct 2017, 21:55 
Offline
*sensei*
User avatar

Joined: 12 Aug 2013, 18:55
Posts: 269
Location: Scotland
I'd like to have realtime var editing, like in the newer ENBs, but uh, I've no idea how to get that rigged up in NVidia's FXComposer. Google didn't give any meaningful results. Same gig with RenderMonkey.

I'd have to somehow take a screenshot without any of the added post processing, and chuck that in as a texture on a plane, then rotate the camera so the plane takes up the whole screen.

Good tip about the global vars, didn't know they were static in older ENBs. I'll see if local vars change anything.

_________________
Intel i7 6700k | AMD HD 7850 2GB | 2x16GB DDR4 @ 3000mhz | Windows 7 64bit | Creative Soundblaster X-Fi Titanium Fatal1ty Pro | Asus z170 Pro Gaming


Top
 Profile  
 
PostPosted: 02 Nov 2017, 21:18 
Offline
*sensei*
User avatar

Joined: 12 Aug 2013, 18:55
Posts: 269
Location: Scotland
Slowly getting there :D

Image

Edit: Made some more changes, fixed image link. It's looking pretty solid now.

_________________
Intel i7 6700k | AMD HD 7850 2GB | 2x16GB DDR4 @ 3000mhz | Windows 7 64bit | Creative Soundblaster X-Fi Titanium Fatal1ty Pro | Asus z170 Pro Gaming


Top
 Profile  
 
PostPosted: 03 Nov 2017, 23:20 
Offline
*sensei*
User avatar

Joined: 12 Aug 2013, 18:55
Posts: 269
Location: Scotland
Got the interior and night variables looking pretty damn good. Updated the OP with the Pastebin for enbeffect.fx

Image

_________________
Intel i7 6700k | AMD HD 7850 2GB | 2x16GB DDR4 @ 3000mhz | Windows 7 64bit | Creative Soundblaster X-Fi Titanium Fatal1ty Pro | Asus z170 Pro Gaming


Top
 Profile  
 
PostPosted: 03 Nov 2017, 23:32 
Offline
*sensei*

Joined: 30 Jan 2012, 13:18
Posts: 483
Your color ranges are totally off, no color ever reaches 255. Try doing color *= something greater than 1 after the tonemap to restore a bit dynamic range if the tonemap itself can't be configured to not kill the ranges.


Top
 Profile  
 
PostPosted: 04 Nov 2017, 01:26 
Offline
*sensei*
User avatar

Joined: 12 Aug 2013, 18:55
Posts: 269
Location: Scotland
Marty McFly wrote:
Your color ranges are totally off, no color ever reaches 255. Try doing color *= something greater than 1 after the tonemap to restore a bit dynamic range if the tonemap itself can't be configured to not kill the ranges.


Yeah, I don't know diddly squat about modifying colours. I don't even know how something is supposed to look "good", just winged it and came up with something that looks cool.

I'll give that a go, see what I can come up with.

_________________
Intel i7 6700k | AMD HD 7850 2GB | 2x16GB DDR4 @ 3000mhz | Windows 7 64bit | Creative Soundblaster X-Fi Titanium Fatal1ty Pro | Asus z170 Pro Gaming


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 18 posts ]  Go to page Previous  1, 2

All times are UTC


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group