Xorchan's Modular ENB Effect.txt Framework
- Author
- Message
-
Offline
- *blah-blah-blah maniac*
- Posts: 17447
- Joined: 27 Dec 2011, 08:53
- Location: Rather not to say
Re: Xorchan's Modular ENB Effect.txt Framework
Have you read what i wrote in previous post about optimization??? And where those other perople? In Obge? They prooved inability to program good shaders.
_________________
i9-9900k, 64Gb RAM, RTX 3060 12Gb, Win7
i9-9900k, 64Gb RAM, RTX 3060 12Gb, Win7
-
Offline
- Posts: 2
- Joined: 09 Sep 2013, 16:17
Re: Xorchan's Modular ENB Effect.txt Framework
Hello. I am currently trying to add some of the sweetfx shaders to your shaders.The sweetfx shaders are H. datas, just like your shaders in fxaa injector.Would it be enough,to add them in the fxaa folder, and add #define ... 1 in the effect.txt ?
-
Offline
- *sensei*
- Posts: 397
- Joined: 16 Mar 2013, 16:28
Re: Xorchan's Modular ENB Effect.txt Framework
Yes that was what i thought, that the external files you supplied where basic (standard) examples.
i presume that if there where more possibilities, you would have put a standard of that in the external files too.
so my question is answered, thanks.
OK, i understand, so if you have external files you need to use a different standard, that explains the problem.
did you ever thought of just skipping those external files ?
i know that some people are not going to like it cause they want to write those external files,
but if it is better like you say, and more powerful, then why keep them.
i presume that if there where more possibilities, you would have put a standard of that in the external files too.
so my question is answered, thanks.
OK, i understand, so if you have external files you need to use a different standard, that explains the problem.
did you ever thought of just skipping those external files ?
i know that some people are not going to like it cause they want to write those external files,
but if it is better like you say, and more powerful, then why keep them.
_________________
Intel I9-9900k, RTX 3070, 1TB Samsung EVO 970, 1TB Crucial SSD, 1TB Kingston SSD , Realtek HD Audio, 16GB 3400MHZ System RAM, W10 Pro x64.
Intel I9-9900k, RTX 3070, 1TB Samsung EVO 970, 1TB Crucial SSD, 1TB Kingston SSD , Realtek HD Audio, 16GB 3400MHZ System RAM, W10 Pro x64.
-
Offline
- *blah-blah-blah maniac*
- Posts: 17447
- Joined: 27 Dec 2011, 08:53
- Location: Rather not to say
Re: Xorchan's Modular ENB Effect.txt Framework
This is wrong place to discuss such things and i can't drop support to features which are widely used.
_________________
i9-9900k, 64Gb RAM, RTX 3060 12Gb, Win7
i9-9900k, 64Gb RAM, RTX 3060 12Gb, Win7
-
Offline
- *sensei*
- Posts: 397
- Joined: 16 Mar 2013, 16:28
Re: Xorchan's Modular ENB Effect.txt Framework
i understand.
_________________
Intel I9-9900k, RTX 3070, 1TB Samsung EVO 970, 1TB Crucial SSD, 1TB Kingston SSD , Realtek HD Audio, 16GB 3400MHZ System RAM, W10 Pro x64.
Intel I9-9900k, RTX 3070, 1TB Samsung EVO 970, 1TB Crucial SSD, 1TB Kingston SSD , Realtek HD Audio, 16GB 3400MHZ System RAM, W10 Pro x64.
-
Offline
- *master*
- Posts: 129
- Joined: 05 Jul 2012, 12:22
Re: Xorchan's Modular ENB Effect.txt Framework
Can someone tell me what I'm doing wrong here? I'm trying to add the vibrance effect from http://skyrim.nexusmods.com/mods/41905/? to effect.txt, which works, as long as I use only that in effect.txt. The problem is, if I add anything from this to effect.txt, then I lose the spinner for the vibrance effect.
-
Offline
- *blah-blah-blah maniac*
- Posts: 17447
- Joined: 27 Dec 2011, 08:53
- Location: Rather not to say
Re: Xorchan's Modular ENB Effect.txt Framework
Use FX Composer to edit shaders, for sure you have duplicate names of something.
_________________
i9-9900k, 64Gb RAM, RTX 3060 12Gb, Win7
i9-9900k, 64Gb RAM, RTX 3060 12Gb, Win7
-
Offline
- *master*
- Posts: 129
- Joined: 05 Jul 2012, 12:22
Re: Xorchan's Modular ENB Effect.txt Framework
Thanks. I'll take a look at that.
edit: OK, yeah, it looks like I'm going to have to try to merge the effects, but it's exactly as you said... duplicate definitions. This should keep me busy for awhile.
edit: OK, yeah, it looks like I'm going to have to try to merge the effects, but it's exactly as you said... duplicate definitions. This should keep me busy for awhile.
-
Offline
- *sensei*
- Posts: 397
- Joined: 16 Mar 2013, 16:28
Re: Xorchan's Modular ENB Effect.txt Framework
I suspect that the vertex shader needs to be stripped from the vibrance effect, cause as far as i understand you don't want to do these vertex computations twice.
It is already opened in common.fxh then the pixelshaders are done in the shaders that come after common.fxh and then the technique.fxh closes by returning/closing the vertex and pixel shaders.
And the existing vertex computations need to be altered in the common.fxh file.
If you can't get it to work you can Always just use the naturalcolors.fxh shader, that works fine chained.
It is already opened in common.fxh then the pixelshaders are done in the shaders that come after common.fxh and then the technique.fxh closes by returning/closing the vertex and pixel shaders.
And the existing vertex computations need to be altered in the common.fxh file.
If you can't get it to work you can Always just use the naturalcolors.fxh shader, that works fine chained.
_________________
Intel I9-9900k, RTX 3070, 1TB Samsung EVO 970, 1TB Crucial SSD, 1TB Kingston SSD , Realtek HD Audio, 16GB 3400MHZ System RAM, W10 Pro x64.
Intel I9-9900k, RTX 3070, 1TB Samsung EVO 970, 1TB Crucial SSD, 1TB Kingston SSD , Realtek HD Audio, 16GB 3400MHZ System RAM, W10 Pro x64.
-
Offline
- *sensei*
- Posts: 391
- Joined: 03 Oct 2012, 06:12
- Location: Ottawa, Canada
Re: Xorchan's Modular ENB Effect.txt Framework
Regarding priorities in the shaders, how would the order of the shaders be loaded? And if it's possible to set the load order of the shaders, where would you designate it? In the technique.fxh, common.fxh, or the effect.txt file?
EDIT: I have done some effects in the .fxh files to have better sharpening chained with blur-shift effect that you (Boris) posted here beforehand. That might have been the alternative solution to have the order selected as I wanted. However, some effects I'd like to have separate files, and likewise a proper order in the chain to render it.
For instance, from first to last in terms of the effects rendered:
FXAA.fxh
BlurShift.fxh
Sharpen.fxh
NaturalColors.fxh
PostSharpen.fxh
..... and etc, etc.
EDIT: I have done some effects in the .fxh files to have better sharpening chained with blur-shift effect that you (Boris) posted here beforehand. That might have been the alternative solution to have the order selected as I wanted. However, some effects I'd like to have separate files, and likewise a proper order in the chain to render it.
For instance, from first to last in terms of the effects rendered:
FXAA.fxh
BlurShift.fxh
Sharpen.fxh
NaturalColors.fxh
PostSharpen.fxh
..... and etc, etc.